[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio] Feedback for CSPRD03
On Mon, Jul 21, 2014 at 03:06:57PM +0100, Pawel Moll wrote: > Greetings, > > I've finally managed to "convince" one of my colleagues to provide some > feedback. Thanks, Brian! (I'm just acting as an IPR proxy here...) I saw that you already sent patches for most things. Thanks! I think the only things left are: > * 3.1.2 "Legacy devices do not support the FEATURES_OK status bit, and > thus did not have a graceful way for the device to indicate > unsupported > feature combinations. It also did not provide a clear mechanism to > end feature negotiation, which meant that devices finalized features > on > first-use, and no features could be introduced which radically changed > the initial operation of the device." > > This has mixed tenses ("do not"/"did not"/"which meant"). Probably > should all be present tense, since all the statements are still true > of > legacy devices now as well as in the past. > and > * 4.2 "Therefore most of operations like..." > > Should be "Therefore most operations including" > Correct? Could you please create issues for stuff that is left, so we can fix?