[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio] Feedback for CSPRD03
On Wed, Jul 30, 2014 at 02:20:37PM +0200, Michael S. Tsirkin wrote: > On Wed, Jul 30, 2014 at 01:46:49PM +0200, Michael S. Tsirkin wrote: > > On Wed, Jul 23, 2014 at 12:50:09PM +0100, Pawel Moll wrote: > > > On Tue, 2014-07-22 at 20:25 +0100, Michael S. Tsirkin wrote: > > > > I think the only things left are: > > > > > > > > > * 3.1.2 "Legacy devices do not support the FEATURES_OK status bit, and > > > > > thus did not have a graceful way for the device to indicate > > > > > unsupported > > > > > feature combinations. It also did not provide a clear mechanism to > > > > > end feature negotiation, which meant that devices finalized features > > > > > on > > > > > first-use, and no features could be introduced which radically changed > > > > > the initial operation of the device." > > > > > > > > > > This has mixed tenses ("do not"/"did not"/"which meant"). Probably > > > > > should all be present tense, since all the statements are still true > > > > > of > > > > > legacy devices now as well as in the past. > > > > > > https://issues.oasis-open.org/browse/VIRTIO-112 > > > > Looks like environment is not set to include the reporter. > > > > If Brian doesn't want to keep his name secret, > > please set environment to reporter's name and optionally > > email address. > > If it's a secret, please set yours there instead. > > Ugh I see it now. Donnu why I missed it, sorry. > > Minor issue: <> got converted to < >. > This seems to be a bug when creating issues. > I fixed it up for environment for this bug, could affect > other bugs. > > Same affects descriptions as well. > > At the moment because of this bug it seems best to create empty issues, > then press edit to fill in the data. > Edit does not seem to suffer from this problem. > > Also pls do not add "Reported-by:" in environment, > makes it harder to extract addresses automatically. > > > Thanks! Also, affects versions should be set at least to csprd03. After fixing, pls set it to csprd04 (if we don't go for prd04 I will rename the version, this is not a problem). > > > > > * 4.2 "Therefore most of operations like..." > > > > > > > > > > Should be "Therefore most operations including" > > > > > > The second thing should be actually included in the MMIO fix, will add. > > > > > > Paweł > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe from this mail list, you must leave the OASIS TC that > > > generates this mail. Follow this link to all your TCs in OASIS at: > > > https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]