OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [virtio-dev] [PATCH v3] virtio-blk: add discard and write zeroes features to specification



> -----Original Message-----
> From: virtio-dev@lists.oasis-open.org [mailto:virtio-dev@lists.oasis-open.org] On
> Behalf Of Stefan Hajnoczi
> Sent: Wednesday, March 7, 2018 7:29 PM
> To: Liu, Changpeng <changpeng.liu@intel.com>
> Cc: virtio-dev@lists.oasis-open.org; virtio-comment@lists.oasis-open.org;
> cavery@redhat.com; pbonzini@redhat.com; Wodkowski, PawelX
> <pawelx.wodkowski@intel.com>; Harris, James R <james.r.harris@intel.com>
> Subject: Re: [virtio-dev] [PATCH v3] virtio-blk: add discard and write zeroes
> features to specification
> 
> On Tue, Mar 06, 2018 at 10:50:20AM +0800, Changpeng Liu wrote:
> > +The \field{data} used for discard or write zeroes command is described
> > +by one or more virtio_blk_discard_write_zeroes structs. \field{sector}
> > +indicates the starting offset (multiplied by 512) of the segment, while
> 
> Did you mean "divided by 512 bytes" instead of "multiplied by 512"?
I saw the original expression for `sector` field used "multiplied by 512", so here just
follow it, should here use "expressed by 512-byte", maybe this looks more clear to
readers.


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]