OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [virtio-comment] content: RSC extension support for virtio-net


On Mon, Oct 15, 2018 at 12:41:30PM +0300, Yuri Benditovich wrote:
> Allocates feature bit for extended RSC (receive
> side coalescing) support. If the device supports
> this feature, it is able to process duplicated
> ACKs and report number of coalesced TCP segments
> amd number of received duplicated ACKs.
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/20
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
> ---
>  content.tex | 39 ++++++++++++++++++++++++++++++---------
>  1 file changed, 30 insertions(+), 9 deletions(-)
> 
> diff --git a/content.tex b/content.tex
> index be18234..17d83af 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2525,6 +2525,10 @@ features.
>  
>  \item[VIRTIO_NET_F_CTRL_MAC_ADDR(23)] Set MAC address through control
>      channel.
> +
> +\item[VIRTIO_NET_F_RSC_EXT(38)] Device can process duplicated ACKs
> +    and report number of coalesced segments and duplicated ACKs
> +
>  \end{description}
>  
>  \subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device / Feature bits / Feature bit requirements}

So I went to apply this and I noticed that other devices started
growing from bit 64 downward. So e.g. VIRTIO_NET_F_STANDBY is bit 62
now. Is it to late to tweak this bit to match? E.g. to use bit 61?
Or was some driver with this feature already get released?

-- 
MST


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]