OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [virtio-comment] virtio 1.1 features question


On Thu, 21 Feb 2019 10:29:14 -0500
Don Wallwork <don.wallwork@broadcom.com> wrote:

> Is there an expectation that feature names in the spec would match 
> implementation in code?
> I presume not, since features like VIRTIO_F_EVENT_IDX and 
> VIRTIO_F_INDIRECT_DESC do not
> appear in Linux kernel or QEMU code; VIRTIO_RING_F_EVENT_IDX and 
> VIRTIO_RING_F_INDIRECT_DESC
> are used instead.

I'd say matching the names is nice, but not required.

> 
> Also noticed that there seems to be an inconsistency in the spec in that 
> VIRTIO_F_EVENT_IDX is
> used in some places and VIRTIO_F_RING_EVENT_IDX is used in others.. Is 
> this intended?

This looks like a bug... the same things should use the same names.
Might be a good idea to switch both to the name used in Linux/QEMU?


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]