[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH v3 1/3] shared memory: Define shared memory regions
* Stefan Hajnoczi (stefanha@redhat.com) wrote: > On Mon, Mar 04, 2019 at 01:25:29PM +0000, Dr. David Alan Gilbert (git) wrote: > > +\subsection{Addressing within regions}\label{sec:Basic Facilities of a Virtio Device / Shared Memory Regions / Addressing within regions } > > + > > +Commands sent over the virtqueues may refer to data within the > > +shared memory regions, for example a command may be used by a > > +driver to cause a device to add or remove a mapping within > > +a region. When referring to data, the addresses will normally be > > +offsets within a particular region rather than absolute host or > > +guest addresses. The \field{shmid} may be explicit or may be > > +inferred from the command type. > > This sounds like normative statements. They belong in a driver or > device normative section. I think we were trying in a previous version to make it one; but the problem is it's not really a statement about something a device or driver must do; it's a statement advising someone writing the spec for a particular device to make sure it's specified like that. > Otherwise: > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Thanks. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]