OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [virtio-comment] [PATCH] virtio-net: add missing articles for new hdr_len feature


On Wed, Nov 20, 2019 at 11:10:23AM +0000, Stefan Hajnoczi wrote:
> On Wed, Nov 20, 2019 at 09:29:41AM +0100, Cornelia Huck wrote:
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> > 
> > Note: I have not added definite articles to the feature description; _all_
> > features for virtio-net are described in that way, and we should add them
> > in one go should we decide to change that.
> > 
> > ---
> >  content.tex | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/content.tex b/content.tex
> > index 5d3f865956aa..452763bbbbc4 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
> >    \begin{itemize}
> >    \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
> >      \field{hdr_len} indicates the header length that needs to be replicated
> > -    for each packet. It's a number of bytes from beginning of the packet
> > -    to beginning of the transport payload.
> > +    for each packet. It's a number of bytes from the beginning of the packet
> > +    to the beginning of the transport payload.
> 
> Another opportunity to tweak the text:
> s/a number of bytes/the number of bytes/ is slightly clearer
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Post a patch? Or are you asking Cornelia to integrate that into hers?



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]