OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: Re: [virtio-comment] Re: [EXT] Re: [virtio-comment] Re: [PATCH] virtio-net: Add equal-sized receive buffers feature

On 2019/11/25 äå4:18, Michael S. Tsirkin wrote:
Again I can see how we might want to disallow crazy setups with e.g. 1
byte per buffer. That's just abuse, no guest does that anyway. So asking
e.g. for a minimal buffer size sounds very reasonable.
One question here is that, the minimal buffer size should depends on various
factors. E.g the ring size. Consider a 256 entries ring, the minimal size
should be 64K/256=256 ...
I guess you are right. We can make this driver programmable I guess?
Basically pass min_buf_len to the device.
Then it still have the chance to program the min_buf_len to 1?
If it wants to - yes - presumably device won't work as well,
fetching all kind of extra data e.g. unnecessary descriptors.

Technically, device should still work for small packet and drop large packet.

Vhost has a bug that will stall RX in the case.

Will post a fix.


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]