[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [PATCH] virtio-net: Fix VIRTIO_NET_F_GUEST_HDRLEN feature definition.
Requesting the TC vote. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/72 >-----Original Message----- >From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-open.org> On Behalf Of Vitaly >Mireyno >Sent: Monday, 24 February, 2020 10:15 >To: virtio-comment@lists.oasis-open.org >Cc: Michael S. Tsirkin <mst@redhat.com>; Jason Wang <jasowang@redhat.com> >Subject: [EXT] [virtio-comment] [PATCH] virtio-net: Fix VIRTIO_NET_F_GUEST_HDRLEN feature >definition. > >External Email > >---------------------------------------------------------------------- >Fix driver and device requirements with regards to the VIRTIO_NET_F_GUEST_HDRLEN feature - >'hdr_len' must be accurate only for TSO/UFO packets. > > >Signed-off-by: Vitaly Mireyno <vmireyno@marvell.com> >--- > content.tex | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/content.tex b/content.tex >index b91a132..2f71f8f 100644 >--- a/content.tex >+++ b/content.tex >@@ -3354,10 +3354,12 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network >Device / De been negotiated: > \begin{itemize} > \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated, >+ and \field{gso_type} differs from VIRTIO_NET_HDR_GSO_NONE, > the driver MUST set \field{hdr_len} to a value equal to the length > of the headers, including the transport header. > > \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated, >+ or \field{gso_type} is VIRTIO_NET_HDR_GSO_NONE, > the driver SHOULD set \field{hdr_len} to a value > not less than the length of the headers, including the transport > header. >@@ -3379,6 +3381,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network >Device / De been negotiated: > \begin{itemize} > \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated, >+ and \field{gso_type} differs from VIRTIO_NET_HDR_GSO_NONE, > the device MAY use \field{hdr_len} as the transport header size. > > \begin{note} >@@ -3387,6 +3390,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network >Device / De > \end{note} > > \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated, >+ or \field{gso_type} is VIRTIO_NET_HDR_GSO_NONE, > the device MAY use \field{hdr_len} only as a hint about the > transport header size. > The device MUST NOT rely on \field{hdr_len} to be correct. >-- > >This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. > >In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, >subscription is required before posting. > >Subscribe: virtio-comment-subscribe@lists.oasis-open.org >Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org >List help: virtio-comment-help@lists.oasis-open.org >List archive: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.oasis- >2Dopen.org_archives_virtio- >2Dcomment_&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=lDHJ2FW52oJ3lqqsArgFRdcevq01tbLQAw4 >A_NO7xgI&m=s2vGdCsfEuMUdZHoeL9LV3F8NllsMi5EEA7xgPtCySY&s=ZtW2HQ5wF6tUDmDeIim_cKxjP >jZnmNjoQGjuQvwIlOk&e= >Feedback License: https://urldefense.proofpoint.com/v2/url?u=https-3A__www.oasis- >2Dopen.org_who_ipr_feedback- >5Flicense.pdf&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=lDHJ2FW52oJ3lqqsArgFRdcevq01tbLQAw4 >A_NO7xgI&m=s2vGdCsfEuMUdZHoeL9LV3F8NllsMi5EEA7xgPtCySY&s=AZTZGyXdBgyRhFsqZ1- >kjNGh8AbJO2BIXii6q04saHE&e= >List Guidelines: https://urldefense.proofpoint.com/v2/url?u=https-3A__www.oasis- >2Dopen.org_policies-2Dguidelines_mailing- >2Dlists&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=lDHJ2FW52oJ3lqqsArgFRdcevq01tbLQAw4A_NO7 >xgI&m=s2vGdCsfEuMUdZHoeL9LV3F8NllsMi5EEA7xgPtCySY&s=X2nk_0Ai93ogh9npaBpUQ892KeTF4ybf >eVoPZF7FilI&e= >Committee: https://urldefense.proofpoint.com/v2/url?u=https-3A__www.oasis- >2Dopen.org_committees_virtio_&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=lDHJ2FW52oJ3lqqsArgF >Rdcevq01tbLQAw4A_NO7xgI&m=s2vGdCsfEuMUdZHoeL9LV3F8NllsMi5EEA7xgPtCySY&s=TvkAqDitaPL >AsrovTf56zDSopHU-8oZLYg2cvJOTaUk&e= >Join OASIS: https://urldefense.proofpoint.com/v2/url?u=https-3A__www.oasis- >2Dopen.org_join_&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=lDHJ2FW52oJ3lqqsArgFRdcevq01tbLQ >Aw4A_NO7xgI&m=s2vGdCsfEuMUdZHoeL9LV3F8NllsMi5EEA7xgPtCySY&s=Ky2KClCJihmZaDJ4bf8vVt-- >cL5YSDkVEaTUoGsySa0&e=
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]