OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: [PATCH] virtio-console: swap cols,rows fields in struct virtio_console_resize

I would like to propose a change to the order of these fields to match
the implementation in the Linux Kernel. I checked that FreeBSD and
OpenBSD do not implement the virtio feature using this struct.

If there is some less popular implementation of virtio driver that uses
the same order as the current version of the spec then I would like to
leave it to a hypervisor to deal with this issue, i.e. it should be
outside the scope of the virtio spec.

Signed-off-by: Szymon Lukasz <noh4hss@gmail.com>
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/content.tex b/content.tex
index 91735e3..f95e708 100644
--- a/content.tex
+++ b/content.tex
@@ -4886,8 +4886,8 @@ \subsubsection{Multiport Device Operation}\label{sec:Device Types / Console Devi
   a console size change.  \field{value} is unused.  The buffer is followed by the number of columns and rows:
 struct virtio_console_resize {
-        le16 cols;
         le16 rows;
+        le16 cols;
 \item [VIRTIO_CONSOLE_PORT_OPEN (6)] This message is sent by both the

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]