Re: [virtio-comment] Re: [PATCH v5 2/3] content: Document balloon feature free page reporting

[Alexander Duyck <alexander.duyck@gmail.com>]

On Wed, Jul 8, 2020 at 4:17 AM Cornelia Huck <cohuck@redhat.com> wrote:
>
> On Mon, 06 Jul 2020 14:18:28 -0700
> Alexander Duyck <alexander.duyck@gmail.com> wrote:
>
> > From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> >
> > Free page reporting is a feature that allows the guest to proactively
> > report unused pages to the host. By making use of this feature is is
> > possible to reduce the overall memory footprint of the guest in cases where
> > some significant portion of the memory is idle. Add documentation for the
> > free page reporting feature describing the functionality and requirements.
> >
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> > ---
> >  conformance.tex |    2 +
> >  content.tex     |   89 +++++++++++++++++++++++++++++++++++++++++++++++++++++--
> >  2 files changed, 87 insertions(+), 4 deletions(-)
>
> (...)
>
> > @@ -5088,10 +5097,16 @@ \subsection{Device Initialization}\label{sec:Device Types / Memory Balloon Devic
> >  \item If the VIRTIO_BALLOON_F_PAGE_POISON feature bit is negotiated, the
> >    driver updates the \field{poison_val} configuration field.
> >
> > +\item If the VIRTIO_BALLOON_F_PAGE_REPORTING feature bit is negotiated the
>
> s/negotiated/negotiated,/

Done

> > +  reporting_vq is identified.
>
> Again, maybe use "identify the reporting_vq", just to keep the wording
> more consistent?

Sounds good to me. I will make the change.

> > +
> >  \item DRIVER_OK is set: device operation begins.
> >
> >  \item If the VIRTIO_BALLOON_F_STATS_VQ feature bit is negotiated, then
> >    notify the device about the stats virtqueue buffer.
> > +
> > +\item If the VIRTIO_BALLOON_F_PAGE_REPORTING feature bit is negotiated then
>
> s/negotiated/negotiated,/

Done.

> > +  begin reporting free pages to the device.
> >  \end{enumerate}
> >
> >  \subsection{Device Operation}\label{sec:Device Types / Memory Balloon Device / Device Operation}
>
> (...)
>
> Other than those nits, looks good to me.
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Thanks for the review.

- Alex