OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features


On Tue, Aug 25, 2020 at 8:01 AM Cornelia Huck <cohuck@redhat.com> wrote:
>
> On Tue, 25 Aug 2020 07:44:55 -0700
> Alexander Duyck <alexander.duyck@gmail.com> wrote:
>
> > This patch set is meant to add documentation for balloon features that have
> > been recently added to the Linux kernel[1,2] and that were recently added
> > to QEMU[3].
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/84
> >
> > Changes since RFC:
> > Incorporated suggestions from Cornelia Huck
> > Fixed a few additional spelling errors
> >
> > Changes since v1:
> > Incorporated additional suggestions from Cornelia Huck
> > Dropped documentation referring to free page reporting from page poison patch
> >
> > Changes since v2:
> > Rewrote multiple statements based on input from David Hildenbrand
> >   Dropped use of balloon and deflate from page hinting description
> >   Dropped use of free page reporting from page poison description
> >   Cleaned up several spots that didn't match RFC2119 style comments
> >   Added conformance links.
> >   Various other clean-ups.
> > Updated balloon command IDs based on input from Cornelia Huck
> >
> > Changes since v3:
> > Reordered patches to place free page hinting at end of patch set
> >   Moved contents out of patch to poison and free page reporting patches
> >   Updated patch description to document some known issues with feature
> > Further clean-ups based on input from David Hildenbrand
> >
> > Changes since v4:
> > Further clean-ups for page hinting based on input from David Hildenbrand
> >
> > Changes since v5:
> > Reverted patcher order changes from v3 placing hinting as first patch
> > Addressed comments and added Reviewed-by from Cornelia Huck
> > Addressed further items I found in free page hinting
> >   Added requirement that output buffers be 4 bytes in size
> >   Replaced reference to descriptor with buffer
> >   Replaced references to free_page_hint_vq with free_page_vq
> >
> > Changes since v6:
> > Fixed line that was left over from a merge conflict
> > Added Reviewed-by from David Hildenbrand
> > Created issue and added "Fixes" to cover page
> >
> > Changes since v7:
> > Removed comments from patch 1 describing issues that we fixed or addressed
> > Added Acked-by for patch 1 from Cornelia Huck
> >
> > [1]: https://lore.kernel.org/lkml/20200211224416.29318.44077.stgit@localhost.localdomain/
> > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc
> > [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html
> >
> > ---
> >
> > Alexander Duyck (3):
> >       content: Document balloon feature free page hints
> >       content: Document balloon feature page poison
> >       content: Document balloon feature free page reporting
> >
> >
> >  conformance.tex |    6 +
> >  content.tex     |  286 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 286 insertions(+), 6 deletions(-)
> >
> > --
> >
>
> I think this is good to vote on now.

Thanks for the review feedback. If there are no other comments then I
request a vote for inclusion.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/84

- Alex


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]