Re: [virtio-comment] Re: [PATCH v9] virtio-net: Add support for the flexible driver notification structure.

[Halil Pasic <pasic@linux.ibm.com>]

On Mon, 23 Nov 2020 09:38:26 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> I see the reaction is generally positive.
> 
> I had a thought meanwhile - how about changing
> "virt queue number" to "virt queue id" in the notification
> description? we can then explain that the id can be vq number
> or retrieved from config space.
> 
> Thoughts?
> Can be a patch on top does not have to delay vote on this one.

I agree that we should do some cleanup on top. Please also see
my other email. 

My first impression the 'virtqueue id' idea was very positive, but
after some more thought I lost confidence. My concern is that the
potentially arbitrary device generated device unique virtqueue id is
only used for guest->host notification, and only iff the feature
VIRTIO_F_NOTIF_CONFIG_DATA was negotiated. In all other cases
the virtqueue is still identified by the vq number. AFAIU
VIRTIO_F_NOTIF_CONFIG_DATA is currently PCI only (although,
I think it can work with any transport).

Regards,
Halil