OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [RFC PATCH v2] virtio-vsock: use C style defines for constants


On 23.03.2021 15:43, Stefan Hajnoczi wrote:
> On Tue, Mar 23, 2021 at 12:04:44PM +0300, Arseny Krasnov wrote:
>> This:
>> 1) Replaces enums with C style defines.
> Why? Please include the rationale for this change in the commit
> description.
Ack
>
>> @@ -227,6 +226,11 @@ \subsubsection{Stream Sockets}\label{sec:Device Types / Socket Device / Device O
>>  hints are permanent once sent and successive packets with bits clear do not
>>  reset them.
>>  
>> +\begin{lstlisting}
>> +#define VIRTIO_VSOCK_SHUTDOWN_RECEIVE_BIT 0
>> +#define VIRTIO_VSOCK_SHUTDOWN_SEND_BIT    1
>> +\end{lstlisting}
> Please reference these constants in the text.


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]