Re: [virtio-comment] [PATCH V2 1/2] virtio: introduce virtqueue state as basic facility

[Jason Wang <jasowang@redhat.com>]

å 2021/3/24 äå5:35, Stefan Hajnoczi åé:
> On Wed, Mar 24, 2021 at 04:15:55PM +0800, Jason Wang wrote:
> > å 2021/3/23 äå6:27, Stefan Hajnoczi åé:
> > > On Mon, Mar 22, 2021 at 11:47:16AM +0800, Jason Wang wrote:
> > > > +
> > > > +\devicenormative{\subsection}{Virtqueue State}{Basic Facilities of a Virtio Device / Virtqueue State}
> > > > +
> > > > +If VIRTIO_F_QUEUE_STATE has been negotiated, a device MUST NOT clear
> > > > +the queue state upon reset and MUST reset the queue state when the
> > > > +driver sets ACKNOWLEDGE status bit.
> > > I only see normative sections mentioning getting the virtqueue state but
> > > not setting it. Please explain how setting works.
> >
> > You mean the device normative part? I think the description of avail state
> > and used state can explain itself. Or I miss something?
> Oops, I missed the earlier normative section that says the driver must
> set the virtqueue state after FEATURES_OK but before DRIVER_OK.
>
> When re-reading I noticed that there is a typo: s/FEATURE_OK/FEATURES_OK/.


Will fix.

Thanks


> Stefan