Re: [virtio-comment] [PATCH V2] virtio-gpio: add the device specification

[Viresh Kumar <viresh.kumar@linaro.org>]

On 08-06-21, 13:02, Enrico Weigelt, metux IT consult wrote:
> If newly added features are orthogonal, that would do the job.

Yes they are.

> Yes. Newer versions of the protocol could add more operations like
> setting a bunch of gpios at once (only some HW really supports that, so
> we yet have to sort out whether that should be blindly emulation by host
> or refused - depending on how well this fits in to timing requirements).
> Other new things could be configuring pullup/down (which has some
> overlap with pinmux - some hw does it in the gpio controller, some by
> separate pinmux), debounce filters, level thresholds, etc, etc ...
> 
> For now we're doing just the very basics - switch on/off, perhaps get an
> irq if input changes. The more complex, not so common stuff is left for
> future revisions. And to do that, we need to tell the driver what is
> supported by the device.
> 
> If there's a more granular way instead of just a version number, am
> very fine with that. (A little example would be very appreciated).

I have added a feature (for IRQ) in the new spec, will send it
shortly.

> OTOH, I don't think that an practically not used version field does
> hurt so bad.

-- 
viresh