Re: [virtio-comment] [PATCH] virtio-blk: add secure discard feature to specification

[Stefan Hajnoczi <stefanha@redhat.com>]

On Mon, Nov 22, 2021 at 02:33:57AM +0000, Qi, Yadong wrote:
> > > +\item[VIRTIO_BLK_F_SECDISCARD (16)] Device can support secure discard
> > command,
> > > +    share the same maximum discard sectors size and discard segment number
> > with
> > > +    VIRTIO_BLK_F_DISCARD. Maximum discard sectors size in
> > > +    \field{max_discard_sectors} and maximum discard segment number in
> > > +    \field{max_discard_seg}.
> > 
> > Christoph suggested separate queue limits for secdiscard. Please include this in
> > the spec from the start.
> > 
> > If the guest operating system does not support that and the secdiscard queue
> > limits reported by the device are different from the discard limits, then the driver
> > can disable secdiscard.
> > 
> > This way virtio-blk is future-proof and can also act as the first Linux driver to use
> > secdiscard queue limits.
> > 
> Hi, Hajnoczi and Hellwig
> Do you mean to define a new field like {max_secdiscard_sectors} which differ
> with {max_discard_sectors}?

Yes:
- max_discard_sectors -> max_secdiscard_sectors
- max_discard_seg -> max_secdiscard_seg
- discard_sector_alignment -> secdiscard_sector_alignment

Stefan

Attachment: signature.asc
Description: PGP signature