Re: [virtio-comment] [PATCH v5 1/1] virtio-pmem: Support describing pmem as shared memory region

[Cornelia Huck <cohuck@redhat.com>]

On Tue, Nov 23 2021, Stefan Hajnoczi <stefanha@redhat.com> wrote:

> On Thu, Nov 11, 2021 at 11:52:42AM +0100, Cornelia Huck wrote:
>> On Wed, Nov 10 2021, tstark@linux.microsoft.com wrote:
>> 
>> > From: Taylor Stark <tstark@microsoft.com>
>> >
>> > Update the virtio-pmem spec to add support for describing the pmem region as a
>> > shared memory window. This is required to support virtio-pmem in Hyper-V, since
>> > Hyper-V only allows PCI devices to operate on memory ranges defined via BARs.
>> > When using the virtio PCI transport, shared memory regions are described via
>> > PCI BARs.
>> >
>> > Signed-off-by: Taylor Stark <tstark@microsoft.com>
>> > ---
>> >  conformance.tex | 14 ++++++++++++--
>> >  virtio-pmem.tex | 40 +++++++++++++++++++++++++++++++++-------
>> >  2 files changed, 45 insertions(+), 9 deletions(-)
>> 
>> This looks good to me now.
>
> I noticed the patch uses "guest absolute address" instead of "physical
> address". This terminology was fixed in the original pmem patch and I
> guess the shared memory patch wasn't updated. Please don't use "guest".

So s/guest absolute/physical/ ? That can be fixed as an editorial update
on top.