RE: [PATCH v2] virtio-blk: add secure discard feature to specification

["Qi, Yadong" <yadong.qi@intel.com>]

> -----Original Message-----
> From: hch@lst.de <hch@lst.de>
> Sent: Thursday, November 25, 2021 2:08 PM
> To: Qi, Yadong <yadong.qi@intel.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>; virtio-comment@lists.oasis-
> open.org; hch@lst.de; Chen, Luhai <luhai.chen@intel.com>; Wang, Kai Z
> <kai.z.wang@intel.com>
> Subject: Re: [PATCH v2] virtio-blk: add secure discard feature to specification
> 
> On Thu, Nov 25, 2021 at 01:04:20AM +0000, Qi, Yadong wrote:
> > > Is the meaning of secure discard widely understood or does it make
> > > sense to define it in more detail?
> > Good question, I think I can add more detail. Where is the correct
> > position to add such detail? How about add it under feature bits definition?
> 
> Secure discard is a weird linux-specific term that we certainly would not pick any
> more.  secure erase is much more common in the industry.

How about VIRTIO_BLK_F_SECURE_ERASE and VIRTIO_BLK_T_SECURE_ERASE?
And new fields name: max_secure_erase_sectors, max_secure_erase_seg,
secure_erase_sector_alignment?

Best Regard
Yadong