OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [PATCH] virtio-net: (spelling only) support for receive-side scaling


On Mon, Nov 25, 2019 at 08:34:30PM +0200, Yuri Benditovich wrote:
> Additional patch for previous 'v4 virtio-net: define support for
> receive-side scaling' - contains only spelling fixes.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>

I just noticed that description of Device Initialization has not been
updated with this patch.

For example:

\item Identify and initialize the receive and
  transmission virtqueues, up to N of each kind. If
  VIRTIO_NET_F_MQ feature bit is negotiated,
  N=\field{max_virtqueue_pairs}, otherwise identify N=1.

\item If the VIRTIO_NET_F_CTRL_VQ feature bit is negotiated,
  identify the control virtqueue.

\item Fill the receive queues with buffers: see \ref{sec:Device Types / Network Device / Device Operation / Setting Up Receive Buffers}.

\item Even with VIRTIO_NET_F_MQ, only receiveq1, transmitq1 and
  controlq are used by default.  The driver would send the
  VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET command specifying the
  number of the transmit and receive queues to use.


there are some more instances of this.

I created https://github.com/oasis-tcs/virtio-spec/issues/135
to track this.
Also, https://github.com/oasis-tcs/virtio-spec/issues/134 since
VIRTIO_NET_F_MQ name is now confusing.


Yuri, could you try to address these?

Thanks!

-- 
MST



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]