[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH v2] Introduction of Virtio Network device notifications coalescing feature
å 2022/5/17 23:50, Alvaro Karsz åé:
This reasoning applies to rx but not tx. It would be fine to disable the timer since the driver controls tx buffer submission.
The driver is required to some post processing after a packet has been sent.A well behaved driver should rely somehow on the tx interrupt. It can provide the accounting timely which may help for the TCP performance.
I'm not sure I understand why this can't happen in TX. Assume the following situation: tx-max-frames is 10. The driver wants to send 5 packets (ideal case, every packet is small enough to fit in one buffer), then no more packets to send for a long time. If event suppression isn't on, the driver won't know that the descriptors were used by device, since the device won't interrupt the driver. I'm assuming that the driver won't check the descriptor flags without being interrupted, which seems like a "good" behaviour when event suppression isn't on. Am I missing something?
Maybe we can say the driver should not disable timer. Thanks
Alvaro
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]