[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH v3] virtio-vsock: add max payload size config field
On Thu, Apr 21 2022, Laura Loghin <lauralg@amazon.com> wrote: > Added a new field to the vsock device config space that > is limiting the size of the packet payload. This way > the driver is not allowed to allocate huge buffers, and > potentially fill up the entire memory. > Also defined a new feature bit for this, VIRTIO_VSOCK_F_SIZE_MAX, > in order to keep backwards compatibility. > > Signed-off-by: Laura Loghin <lauralg@amazon.com> > --- > virtio-vsock.tex | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > +\devicenormative{\subsubsection}{Device configuration layout}{Device Types / Socket Device / Device configuration layout} > + > +The device MUST NOT change the value exposed through \field{data_max_size}. > + > +\drivernormative{\subsubsection}{Device configuration layout}{Device Types / Socket Device / Device configuration layout} > + > +A driver SHOULD negotiate VIRTIO_VSOCK_F_SIZE_MAX if the device offers it. > + > +If the driver negotiates VIRTIO_VSOCK_F_SIZE_MAX, the receive buffers it > +supplies for a packet MUST have a total size that doesn't exceed the size > +\field{data_max_size} (plus header length). > + > +If the driver negotiates VIRTIO_VSOCK_F_SIZE_MAX, it MUST NOT transmit packets > +of size exceeding the value of \field{data_max_size} (plus header length). > + > \subsection{Device Initialization}\label{sec:Device Types / Socket Device / Device Initialization} > > \begin{enumerate} I think you need to hook up the two new sections in conformance.tex.
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]