[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] RE: [PATCH v5 2/7] Introduce admin command set
On Tue, May 31, 2022 at 08:39:24PM +0000, Parav Pandit wrote: > > And as I said, you will need much more spec work to reach the level to which > > features are specified - and note we are not yet happy with how features are > Can you be specific of the work that you are expecting in this v5 version? I proposed getting rid of attrs_mask/device_admin_caps and instead specify that e.g. feature bits 64 to 95 are reserved for management purposes. Maybe just add a 32 bit register, or maybe "extended features" with a selector and length like mmio and ccw already do, up to you. I think Cornelia likes this suggestion too. This would replace functionality of the VIRTIO_ADMIN_DEVICE_CAPS_IDENTIFY/VIRTIO_ADMIN_DEVICE_CAPS_ACCEPT commands and have the advantage of being generally well specified and understood. Is this acceptable? Or is there a reason the new commands are preferable? -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]