Re: [virtio-comment] [PATCH v7] Introduction of Virtio Network device notifications coalescing feature.

[Alvaro Karsz <alvaro.karsz@solid-run.com>]

Hi Jason,

> Note that the keyword "SHOULD" must be used in the normative part.

Please note that this is not the "Driver Requirements"/"Device
Requirements" paragraph, but Coalescing and Notifications Suppression.

> So instead of trying to partially duplicate the definition for
> notification suppression, I wonder if we can simply remove this
> example, and add references to the subsection that explains the
> packet/split notification suppression in the first two examples?

How about removing the "Coalescing and Notifications Suppression"
paragraph, and replacing this line (from Device Requirements):

"A device SHOULD NOT send notifications to the driver, if the
notifications are suppressed."

With:

"A device SHOULD NOT send notifications to the driver if the
notifications are suppressed, as explained in {reference to Used
Buffer Notification Suppression}, even if the coalescing counters
expired."

What do you think?