[PATCH] virtio-net : Fix virtio_net_hdr struct size when VIRTIO_NET_F_HASH_REPORT feature is negociated.

[Cyril Germond <cgermond@kalray.eu>]

content.tex    | 4 ++--

split-ring.tex | 6 +++---

2 files changed, 5 insertions(+), 5 deletions(-)

 

diff --git a/content.tex b/content.tex

index e863709..263cb05 100644

--- a/content.tex

+++ b/content.tex

@@ -3620,8 +3620,8 @@ \subsubsection{Setting Up Receive Buffers}\label{sec:Device Types / Network Devi

features are used, the maximum incoming packet

will be to 65550 bytes long (the maximum size of a

TCP or UDP packet, plus the 14 byte ethernet header), otherwise

-1514 bytes.  The 12-byte struct virtio_net_hdr is prepended to this,

-making for 65562 or 1526 bytes.

+1514 bytes.  The 12-byte (or 16-byte if VIRTIO_NET_F_HASH_REPORT feature has been negotiated) struct virtio_net_hdr is prepended to this,

+making for 65562 or 1526 bytes (respectively 65566 and 1530 bytes if VIRTIO_NET_F_HASH_REPORT has been negotiated).

 

\drivernormative{\paragraph}{Setting Up Receive Buffers}{Device Types / Network Device / Device Operation / Setting Up Receive Buffers}

 

diff --git a/split-ring.tex b/split-ring.tex

index de94038..e6953d7 100644

--- a/split-ring.tex

+++ b/split-ring.tex

@@ -128,10 +128,10 @@ \subsection{Legacy Interfaces: A Note on Virtqueue Endianness}\label{sec:Basic F

\subsection{Message Framing}\label{sec:Basic Facilities of a Virtio Device / Virtqueues / Message Framing}

The framing of messages with descriptors is

independent of the contents of the buffers. For example, a network

-transmit buffer consists of a 12 byte header followed by the network

+transmit buffer consists of a 12 (or 16 if VIRTIO_NET_F_HASH_REPORT feature has been negociated) byte header followed by the network

packet. This could be most simply placed in the descriptor table as a

-12 byte output descriptor followed by a 1514 byte output descriptor,

-but it could also consist of a single 1526 byte output descriptor in

+12 (or 16) byte output descriptor followed by a 1514 byte output descriptor,

+but it could also consist of a single 1526 (or 1530) byte output descriptor in

the case where the header and packet are adjacent, or even three or

more descriptors (possibly with loss of efficiency in that case).