Re: [virtio-dev] [PATCH] virtio_net: support low and high rate of notification coalescing sets

[Heng Qi <hengqi@linux.alibaba.com>]

å 2022/12/21 äå7:48, Alvaro Karsz åé:
> Hi,
>
> > I want to know which one is better than NetDim(Coalesce Adaptive) in driver.
> >
> > I know Heng Qi's work in this.
> >
> > Thanks
>
> Why choose? we can have both.
> ethtool can handle both pkt_rate_low/pkt_rate_high and
> use_adaptive_rx_coalesce/use_adaptive_tx_coalesce.
>
> The adaptive algorithm can even use this feature to set low and high
> coalescing sets.

Hi, all.


NetDIM is currently a mature library in the kernel. It uses the number 
of bytes, PPS and interrupt rate

as samples to make an action, and it is performed independently in tx or 
rx direction. Also, There will

be an extra worker to help us send the configuration based on the 
control queue to avoid interrupting
the softirq. Although the method of pkt_rate_{low, high} params does not 
conflict with dim, I seem

to have some doubts that the colasce parameters of the rx and tx 
directions are determined at the

same time based on pkt_rate alone, will this be a problem?


Thanks.

> Alvaro