RE: [PATCH v4] virtio-network: Clarify VLAN filter table configuration

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Wednesday, January 4, 2023 1:41 AM
> 
> On Wed, Jan 04, 2023 at 06:02:05AM +0200, Parav Pandit wrote:
> > The filtering behavior of the VLAN filter commands is not very clear
> > as discussed in thread [1].
> >
> > Hence, add the command description and device requirements for it.
> >
> > [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg912392.html
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/147
> > Suggested-by: Si-Wei Liu <si-wei.liu@oracle.com>
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> 
> Looks like we are going back to issues that we had in v1.
> what happened here?
> 
I was missing text in v3 for the case of device behavior for handling vlan tagged packets when CTRL_VLAN is not negotiated.
Which I added in v4. Parts of the v1 was taken care. More below.
[..]
> > +
> > +VIRTIO_NET_CTRL_VLAN_DEL command removes specified VLAN from the
> VLAN
> 
> the specified
> 
Ack.

> > +filtering table which was previously added using
> > +VIRTIO_NET_CTRL_VLAN_ADD command.
> 
> bad ordering so it's unclear what was added. it's vlan not the table. So:
> 	removes the specified VLAN - which was previously added using
> 	VIRTIO_NET_CTRL_VLAN_ADD command - from the VLAN filtering
> table.
>
Ack.
 
> > +
> > +\devicenormative{\subparagraph}{VLAN Filtering}{Device Types /
> > +Network Device / Device Operation / Control Virtqueue / VLAN
> > +Filtering}
> > +
> > +When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device accepts all
> > +VLAN tagged packets that matches the device's filter configuration.
> 
> bad grammar here and it's not a match.
> 
How about, 

When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device accepts 
all VLAN tagged packets based on the device configuration.

Above spec line covers 
(a) existing mac filter table entries
(b) promiscuous variations and 
(c) future filtering rules.