Re: [PATCH] virtio_net: support low and high rate of notification coalescing sets

[Alvaro Karsz <alvaro.karsz@solid-run.com>]

> > is it really true we always want the same rate for tx and rx?
> > why not separate commands for each? this is the way we went
> > for general coalescing at least.
>
> I actually had ethtool in mind while writing the patch.
> AFAIK ethtool has a single rate for both rx and tx low/high, so using
> ethtool to manage the parameters won't be possible.
>
> I know that we should worry about that when trying to implement the
> feature and not while proposing it to the spec, but I think that we
> will benefit the most from this feature if it can be used with an
> existing, well known tool such as ethtool.
>
> What do you think?

ok, we actually could separate tx and rx, and send both commands when
ethtool is used to set low/high rate.
I will fix the patch to have different rx and tx commands.

Alvaro