RE: [PATCH v6] virtio-network: Clarify VLAN filter table configuration

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Sunday, January 8, 2023 10:39 AM
> 
> > +VIRTIO_NET_CTRL_VLAN_ADD command adds the specified VLAN to the
> VLAN
> > +filter table.
> > +
> > +VIRTIO_NET_CTRL_VLAN_DEL command removes the specified VLAN from
> the
> > +VLAN filter table.
> > +
Above two are functional description not placed in the requirements. So no need for normative.

> > +\devicenormative{\subparagraph}{VLAN Filtering}{Device Types /
> > +Network Device / Device Operation / Control Virtqueue / VLAN
> > +Filtering}
> > +
> > +When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device accepts all
> > +VLAN tagged packets as per the device configuration.
> > +
Above one adding must looks fine.

> > +When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device starts with an
> > +empty VLAN filter table.
> > +
I am inclined to move this out of requirements and write in the description along with add/delete command.

> > +When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device accepts all
> > +VLAN tagged packets whose VLAN tag is present in the VLAN filter
> > +table; 

I will add must for above line.

> > the device should drop all VLAN tagged packets whose VLAN tag
> > +is absent in the VLAN filter table. The VLAN filter table applies
> > +only to VLAN tagged packets.
> > +
> 
Above one is written as should will change to "SHOULD".

> We need to make them normative statements. As written they are not.
> Either MUST or SHOULD in this case. I am guessing MUST since this was always
> the intent we just never spelled it out?

Right.