OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [PATCH v3 19/20] virtio-gpio: Maintain gpio device spec in separate directory


> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Wednesday, January 11, 2023 5:52 AM
> 
> On Wed, Jan 11 2023, Parav Pandit <parav@nvidia.com> wrote:
> 
> > Place device specification, its driver and device conformance into its
> > own directory to have self contained device specification.
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > ---
> > changelog:
> > v2->v3:
> > - file name changed from device.tex to description.tex
> > - use input instead of import to insert a file
> > v1->v2:
> > - added missing device conformance reference
> > v0->v1:
> > - new patch
> > ---
> >  conformance.tex                               | 22 ++-----------------
> >  content.tex                                   |  4 ++--
> >  .../virtio-gpio/description.tex               |  0
> >  .../virtio-gpio/device-conformance.tex        |  9 ++++++++
> >  .../virtio-gpio/driver-conformance.tex        |  9 ++++++++
> >  5 files changed, 22 insertions(+), 22 deletions(-)  rename
> > virtio-gpio.tex => device-types/virtio-gpio/description.tex (100%)
> > create mode 100644 device-types/virtio-gpio/device-conformance.tex
> >  create mode 100644 device-types/virtio-gpio/driver-conformance.tex
> 
> (...)
> 
> > diff --git a/content.tex b/content.tex index 977a2cd..bc67e63 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -3020,8 +3020,8 @@ \chapter{Device Types}\label{sec:Device Types}
> > \input{device-types/virtio-mem/description.tex}
> >  \input{device-types/virtio-i2c/description.tex}
> >  \input{device-types/virtio-scmi/description.tex}
> > -\input{virtio-gpio.tex}
> > -\input{virtio-pmem.tex}
> > +\input{device-types/virtio-gpio/description.tex}
> > +\input{device-types/virtio-pmem/description.tex}
> 
> The virtio-pmem change should have gone into the following patch?
> 
It should be in next patch.
The rebasing messed this up.
Bisection is important. Let me fix it.

> (We don't really care about bisectability, so not a big deal; but something that
> should be fixed if a respin is needed.)


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]