RE: [virtio-comment] [PATCH v10] virtio-net: Clarify VLAN filter table configuration

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Wednesday, January 25, 2023 3:32 PM
> 

> > So far I see two comments in version v10 that needs to be addressed.
> > 1. Correct the link the commit message to some past discussion.
> > 2. Drop "as per device configuration"
> >
> > Do you suggest V11?
> > Or it its ok, I prefer to write follow up "Fixes" patch to drop the per device
> configuration part.
> > Given that we are closed to voting deadline, and change is not breaking the
> spec.
> > Usually in other projects for minor things like above #1, maintainer applies
> the local change to commit log before applying the patch to avoid unnecessary
> churn of people's time.
> >
> > Please suggest next step on resolving it.
> 
> Yea #1 does not matter much.
> 
> This ballot
> 	https://lists.oasis-open.org/archives/virtio-
> dev/202301/msg00231.html
> is likely set to approve v10.
> 
> If you really want to withdraw it you can request that.
> 
> Alternatively post a patch on top, if it's a minor cleanup it can be applied
> without a vote. I'd say removing "as per device configuration" is probably a
> minor cleanup.
>
I am in middle of writing this fixes patch.
I will post a patch of this cleanup later today.

[..]
> >
> > In this patch we are not changing the spec.
> 
> Well yes we do :) I think you mean we are not adding new features.
> 
You are right. :)
We are not changing device or driver behavior in this patch...
We are improving/clarifying things in crisp details for betterment.