[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] RE: [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id
On Mon, Apr 03 2023, Parav Pandit <parav@nvidia.com> wrote: >> From: Cornelia Huck <cohuck@redhat.com> >> Sent: Thursday, March 30, 2023 5:17 AM >> > +Field \field{indirection_table} is an array of receive virtqueues. >> >> "an array of receive virtqueues identified via their rss_rq_id" ? > No need to make it this verbose. It is evident from the definition itself. > >> >> > >> > A driver sets \field{max_tx_vq} to inform a device how many transmit >> virtqueues it may use (transmitq1\ldots transmitq \field{max_tx_vq}). >> > >> > @@ -1455,7 +1465,8 @@ \subsubsection{Control >> > Virtqueue}\label{sec:Device Types / Network Device / Devi >> > >> > A driver MUST NOT send the VIRTIO_NET_CTRL_MQ_RSS_CONFIG command >> if the feature VIRTIO_NET_F_RSS has not been negotiated. >> > >> > -A driver MUST fill the \field{indirection_table} array only with indices of >> enabled queues. Index 0 corresponds to receiveq1. >> > +A driver MUST fill the \field{indirection_table} array only with >> > +enabled receive virtqueues. >> >> "only with rss_rq_id references to enabled receive virtqueues" ? >> > In this field and other fields, we just refer to the receive virtqueues as rss_rq_id parent structure itself is describing what it is. > Hence, we omit re-iterating rss_rq_id at multiple places. Personally, I'd prefer to spell it out, as it is a specific way to refer to a virtqueue.
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]