[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names
On Wed, Apr 05, 2023 at 01:21:40PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst@redhat.com> > > Sent: Wednesday, April 5, 2023 1:30 AM > > > > VIRTIO_F_NOTIF_CONFIG_DATA is such a narrow usecase, I don't like burning > > "vq identifier" on this. How about we just say something along the lines of: > > > Ok. > > > > When VIRTIO_F_NOTIFICATION_DATA has not been negotiated, this > > notification involves sending either the virtqueue index or the virtqueue config > > data to the device (method depending on the transport). > > > > And then "the data sent is a device supplied virtqueue config data". > > > Sounds fine. I will reword it. FWIW I like this more than coming up with a cookie term, it is definitely a more conservative approach. -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]