[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names
On Tue, 11 Apr 2023 13:35:09 +0000 Parav Pandit <parav@nvidia.com> wrote: > > From: Cornelia Huck <cohuck@redhat.com> > > Sent: Tuesday, April 11, 2023 4:56 AM > > > > > Yes, please leave it as F_CONFIG_DATA, as we're just putting some "data" > > there in the end (and F_CONFIG_COOKIE might indeed be confusing for the > > ccw case.) > > Since Halil didn't respond for 5+ days + Michel and you propose to continue use CONFIG_DATA and this is rare used field, I will rename > Sorry, this one has fallen through the cracks. For the preceding ones: I do not have a strong opinion. I do share Michael's and Connie's assessment regarding a possible clash with CCW. Let me just note that the feature ain't called, "F_CONFIG_DATA" (i.e. with full name VIRTIO_F_CONFIG_DATA) but rather "F_NOTIF_CONFIG_DATA" (i.e. with full name VIRTIO_F_NOTIF_CONFIG_DATA). > vqn to union of > > vq_index > vq_config_data In that sense vq_config_data is not good in my opinion, because it misses "notif" which is present in both "F_NOTIF_CONFIG_DATA" and "queue_notify_data". > > Thanks. Will roll v13. > I'm about tho have a look how this panned out in v13. I propose let us continue the discussion there. Regards, Halil > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/ >
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]