[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH 1/2] transport-pci: Improve config msix vector description
On Thu, Apr 20, 2023 at 08:51:57PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst@redhat.com> > > Sent: Thursday, April 20, 2023 4:45 PM > > > \item[\field{config_msix_vector}] > > > - The driver sets the Configuration Vector for MSI-X. > > > + The driver writes the MSI-X table entry index in this field for > > > + Configuration change notification interrupts. > > > > > > Urm not exactly. there is also a special value of 0xffff. > > I feel this here is just a high level description. > It is high-level description. 0xffff is already covered elsewhere in the doc. So make it as brief as possible then. > > how about > > Used by the driver to set the MSI-X vector for Configuration change > > notification interrupts. > > > > pci spec also calls the entry "the vector" so I feel it's ok. > > > > To keep the text consistent with rest of the fields, how about > > The driver writes the MSI-X table vector in this field for Configuration change notification interrupts. > It uses a single verb instead two = "used" and "set". >
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]