Re: [virtio-comment] [PATCH] virtio-can: define out of rage can-id

[Matias Ezequiel Vara Larsen <mvaralar@redhat.com>]

Hello,

On Wed, Feb 28, 2024 at 7:15âPM Harald Mommer
<harald.mommer@opensynergy.com> wrote:
>
>
> On 28.02.24 17:15, Matias Ezequiel Vara Larsen wrote:
> > This commit explains when a message is out of range.
> >
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> > * This patch applies on top of virtio-1.4, which has not been released
> >    yet.
> > ---
> >   device-types/can/description.tex | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/device-types/can/description.tex b/device-types/can/description.tex
> > index 2511d9c..0a5cf02 100644
> > --- a/device-types/can/description.tex
> > +++ b/device-types/can/description.tex
> > @@ -191,6 +191,9 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
> >   invalid state with VIRTIO_CAN_RESULT_NOT_OK in \field{result} and MUST
> >   NOT schedule the message for transmission.
> >
> > +Note that a message is out of range when a standard frame uses more than 11
> > +bits of can-id or when an extended frame uses more than 29 bits.
>
>
> "_" and "-" and missing \field{}: It's "\field{can_id}" in the paragraph
> above.
>
> => "can-id" => "\field{can_id}"
>
> Looked through the spec. I did at least not totally forget to mention
> the 11 bits for standard CAN and the 29 bits for extended CAN (line
> 28ff). But could have been expressed more clearly, the note makes it
> clear now.
>

Thanks! I will add those changes in v1.

Matias