Re: [virtio-dev] [PATCH 2/2] Add GPU device type.

[Dave Airlie <airlied@gmail.com>]

On Mon, Mar 24, 2014 at 10:15 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
>> for this reason, I think it's best to do:
>>
>> struct virtgpu_command_hdr {
>>        +     le32 type;
>>        +     le32 flags;
>>        +     le64 fence_id;
>> }
>>
>> and have each command include that implicitly or explicitly.
>
> Makes sense.

I've just moved the implementation and guest driver here over to not
using a union anymore,
http://cgit.freedesktop.org/~airlied/qemu/log/?h=virtio-gpu
http://cgit.freedesktop.org/~airlied/linux/log/?h=virtio-vga-3d

Seems to continue working fine.

>> > +For cursor movement, only \field{cursor_x} and \field{cursor_y} need to be
>> > +updated.
>> > +
>> > +For a cursor update where the guest has transferred a new cursor into
>> > +the resource, \field{cursor_hot_x}, \field{cursor_hot_y} and
>> > +\field{cursor_id} should be updated and \field{generation_count}
>> > +should be increased by one,
>>
>> you mean each successive command as compared to the previous one?
>
> As I understand it:  You create one (or more) cursor resources using
> normal command queue commands.  Then you'll set cursor_id to the
> resource id you want use as cursor, fill the other fields.
> generation_count being incremented (relative to the previous command)
> implies the cursor sprite needs to be reloaded.  same generation_count
> indicates only the position (x & y) has changed.  Correct dave?

Yes correct,

Dave.