[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH qemu 6/6] virtio-input: evdev passthrough
Hi, > > +static void virtio_input_host_event(void *opaque) > > +{ > > + VirtIOInputHost *vhost = opaque; > > I'd prefer a name that does not imply > vhost infrastructure ok. > > + rc = ioctl(vhost->fd, EVIOCGVERSION, &ver); > > + if (rc < 0) { > > + error_setg(errp, "%s: is not an evdev device", vhost->evdev); > > + goto err_close; > > + } > > Hmm is that all? > Don't we want to report versioning info to guests? I guess the only thing we might want to here is bail out in case the major version is != 1 (which implies a incompatible change). The major version didn't change so far though, and I think it is highly unlikely that it'll ever happen. cheers, Gerd
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]