OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: Re: [virtio] [PATCH v2] makediffpdf.sh: tool to create marked-up diff

On Mon, 23 Jun 2014 23:45:14 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> make pdf diff using latexpand and latexdiff-fast
> styles are set in diffpreamble.tex:
> new text is blue, old text is red and is crossed-out.
> in diff, links are coloured green instead of blue

One minor thing I noticed:

If a link was changed (for example, in the conformance section), the old
link is green and crossed out in red and the new one is green. It
*should* be obvious what change was made, but it might be a bit
confusing. I don't think it's worth further tampering around, though.

> Must be run within a git-svn clone of the spec repository.
> Note: latexdiff has --flatten option, this and options
> to select diff style don't seem to work well.
> So flatten by script myself, and add our own preamble.
> A script fixupdiff works around xetex bugs
> 	- \color{ \footnote{text} } does not work,
> 	  replace with \footnote{\textcolor{}}
> 	- too many \color instructions produce
> 	  "color stack overflow. Just ignore" error and
> 	  xetex skips some \color instructions.

That's kind of sad, but probably the best way to get to a usable result
for now.

> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> Changes from v1:
> 	work around xetex bugs
> Output looks ok to me now, plan to commit tomorrow.
> Comments?

I tried it and it seems to produce sensible output. I wonder whether
the resulting pdf should lose the -diff suffix, though?

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]