OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: [RFC v3 5/7] Vhost-vsock: Use nested lock notation

From: Claudio Imbrenda <imbrenda@de.ibm.com>

Since the socket was created locally and wasn't passed around, nobody can
have a reference to it yet, so locking it shouldn't block, therefore no
deadlock should be possible.
I'm not sure why, if at all, it is needed to lock the child socket there,
but this patch makes sure that lockdep is happy, and hopefully it doesn't
mask an actual deadlock.

Signed-off-by: Claudio Imbrenda <imbrenda@de.ibm.com>
 net/vmw_vsock/virtio_transport_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
index fa54359..6698b61 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -792,7 +792,7 @@ virtio_transport_recv_listen(struct sock *sk, struct virtio_vsock_pkt *pkt)
-	lock_sock(child);
+	lock_sock_nested(child, SINGLE_DEPTH_NESTING);
 	child->sk_state = SS_CONNECTED;

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]