Re: [virtio-dev] [PATCH v3 1/7] Vhost-vsock device: Fixed endiannes issue.

[Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>]

On 14/03/16 11:18, Cornelia Huck wrote:
> On Fri, 11 Mar 2016 16:45:48 +0100
> Claudio Imbrenda <imbrenda@linux.vnet.ibm.com> wrote:
>
> > From: Claudio Imbrenda <imbrenda@de.ibm.com>
> >
> > Added missing endianness initializations in the vhost-vsock device.
> >
> > Signed-off-by: Claudio Imbrenda <imbrenda@de.ibm.com>
> > ---
> >   drivers/vhost/vsock.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> > index 2c5963c..9378f23 100644
> > --- a/drivers/vhost/vsock.c
> > +++ b/drivers/vhost/vsock.c
> > @@ -481,6 +481,8 @@ static int vhost_vsock_set_features(struct vhost_vsock *vsock, u64 features)
> >   		vq = &vsock->vqs[i];
> >   		mutex_lock(&vq->mutex);
> >   		vq->acked_features = features;
> > +		vq->is_le = virtio_legacy_is_little_endian();
> > +		vhost_init_is_le(vq);
>
> Hm... I'm not 100% sure that ->set_features() is the right place to
> init this.

actually virtio_legacy_is_little_endian() is called when initializing 
the vhost device in vhost_dev_init(), so it can be removed.

I removed it already from the next revision of the patchset.