Re: [virtio-dev] [PATCH v3 1/7] Vhost-vsock device: Fixed endiannes issue.

[Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>]

On 14/03/16 18:36, Greg Kurz wrote:
> > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> > index 2c5963c..9378f23 100644
> > --- a/drivers/vhost/vsock.c
> > +++ b/drivers/vhost/vsock.c
> > @@ -481,6 +481,8 @@ static int vhost_vsock_set_features(struct vhost_vsock *vsock, u64 features)
> >   		vq = &vsock->vqs[i];
> >   		mutex_lock(&vq->mutex);
> >   		vq->acked_features = features;
> > +		vq->is_le = virtio_legacy_is_little_endian();
> > +		vhost_init_is_le(vq);
>
> How can you call vhost_init_is_le() from here ?

I can't, it's an error, sorry!
Also, as I wrote already earlier, I noticed that that call is not needed 
because that field is initialized already somewhere else. I already 
removed it in my branch and it won't be there in the next version of the 
patchset.

Claudio