Re: [virtio-dev] [PATCH v4] vsock: add vsock device

[Stefan Hajnoczi <stefanha@redhat.com>]

On Tue, Mar 22, 2016 at 12:40:25PM +0200, Michael S. Tsirkin wrote:
> On Tue, Mar 22, 2016 at 09:50:55AM +0000, Ian Campbell wrote:
> > On Mon, 2016-03-21 at 16:54 +0000, Stefan Hajnoczi wrote:
> > > On Mon, Mar 21, 2016 at 12:53:23PM +0000, Ian Campbell wrote:
> > > > > diff --git a/trunk/content.tex b/trunk/content.tex
> > > > > index d989d98..4e9f165 100644
> > > > > --- a/trunk/content.tex
> > > > > +++ b/trunk/content.tex
> > > > > @@ -5641,6 +5641,223 @@ descriptor for the \field{sense_len},
> > > > > \field{residual},
> > > > >  \field{status_qualifier}, \field{status}, \field{response} and
> > > > >  \field{sense} fields.
> > > > > 
> > > > > +\section{Socket Device}\label{sec:Device Types / Socket Device}
> > > > > +
> > > > > +The virtio socket device is a zero-configuration socket
> > > > > communications device.
> > > > > +It facilitates data transfer between the guest and device
> > > > > without using the
> > > > > +Ethernet or IP protocols.
> > > > > +
> > > > > +\subsection{Device ID}\label{sec:Device Types / Socket Device /
> > > > > Device ID}
> > > > > +  13
> > > > The SVN version of the virtio spec seems to include many more
> > > > device id
> > > > allocations, in particular in the table at the start of Section 5
> > > > ("Device Types") it assigns 13 as "memory balloon" (not the
> > > > traditional
> > > > one) and 5.5 ("Traditional Memory Balloon Device") says:
> > > >     This is the traditional balloon device. The device number 13 is
> > > >     reserved for a new memory balloon interface, with different
> > > >     semantics, which is expected in a future version of the
> > > > standard.
> > > Thanks for pointing this out.  I'll select a new device ID.
> > 
> > You probably want to update that table too -- that way you'll get merge
> > conflicts on rebase if you race with someone else.
> > 
> > Or maybe the virtio editors would take a patch which only reserved the
> > number?
> 
> 
> Absolutely, there are already a bunch of reserved numbers.
> Go ahead and split that small part out.

Okay, will do.  Thanks!

Stefan

Attachment: signature.asc
Description: PGP signature