OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [PATCH v4 2/6] virtio-vsock: avoid sleeping where not allowed


On Thu, May 12, 2016 at 06:19:23PM +0200, Claudio Imbrenda wrote:
> On 11/05/16 14:07, Stefan Hajnoczi wrote:
> > On Thu, Mar 31, 2016 at 01:41:34PM +0200, Claudio Imbrenda wrote:
> I don't find it terribly good style to have a "hole" in the scope of the
> lock, but if it works and avoids clumsier/more complex solutions, I'm OK
> totally with it.
> 
> basically the assumption here is that nobody else is dequeueing or otherwise
> messing with the head, so we are the only ones touching the head of the
> list.

Yes, that is the case here since the socket lock prevents other readers
from dequeuing packets until we are finished.  By releasing the lock
we're allowing additional packets to be received while dequeue is stuck
in a page fault.

Stefan

Attachment: signature.asc
Description: PGP signature



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]