OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-dev message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: Re: [virtio-dev] [RFC PATCH v2] virtio-spec: Introduce new Receive-Segment-Coalescing feature for guest

On 2016年06月21日 00:47, Wei Xu wrote:
On 2016年06月20日 13:44, Jason Wang wrote:

On 2016年06月19日 15:29, Wei Xu wrote:
          u8 gso_type;
          le16 hdr_len;
@@ -3256,6 +3264,9 @@
          le16 csum_start;
          le16 csum_offset;
          le16 num_buffers;
+        le16 coalesced_pkts;
+        le16 coalesced_size;
+        le16 dup_acks;

please specify that these are only present if RSC
is negotiated. And maybe name them as rsc_.

We probably need something more flexible in the future. Consider we have
feature X,Y,Z all of which needs new header fields. Who will come first?
Do we need something like TLV in the future?
Yes, that's a good idea, if we were going to support this, do you have any idea about how to adjust current header structure? and this should also consider backward compatibility too, I'm thinking should keep the old one unchanged and make the latter part of the header optional.

Probably need a new feature bit. But I'm not sure whether it's worth for this major changes just for rsc now. Maybe we can use the current header layout and extend it in the future.

For now, since the merge buffer is the default feature, so i'd like to put rsc header after that.

To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]