Re: [virtio-dev][RFC 1/2] content: reserve virtio device ID

[Christian Pinto <c.pinto@virtualopensystems.com>]

Hello Stefan,

On Thu, Jun 23, 2016 at 8:57 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:

On Fri, Jun 17, 2016 at 06:03:13PM +0200, Christian Pinto wrote:
> Signed-off-by: Christian Pinto <c.pinto@virtualopensystems.com>
> ---
>  content.tex | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index d989d98..0d98926 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2990,6 +2990,8 @@ Device ID  &  Virtio Device    \\
>  \hline
>  18         &   Input device \\
>  \hline
> +19         &   Signal Distribution Module \\
> +\hline

Please use a higher number, 19 is already proposed for virtio-vsock:
https://lists.oasis-open.org/archives/virtio-dev/201603/msg00042.html

Thanks, I will use 20 then.

 

> @@ -5641,6 +5643,8 @@ descriptor for the \field{sense_len}, \field{residual},
>  \field{status_qualifier}, \field{status}, \field{response} and
>  \field{sense} fields.
>
> +\input{virtio-sdm.tex}

Please move this to the patch that adds virtio-sdm.tex.  Each patch must
be self-contained and build successfully.

Right, I will add this change to the patch adding the device specification text.

Best,

Christian