RE: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff

["Gonglei (Arei)" <arei.gonglei@huawei.com>]

> -----Original Message-----
> From: Daniel P. Berrange [mailto:berrange@redhat.com]
> Sent: Tuesday, September 13, 2016 6:09 PM
> To: Gonglei (Arei)
> Subject: Re: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff
> 
> On Tue, Sep 13, 2016 at 10:05:01AM +0000, Gonglei (Arei) wrote:
> >
> >
> > > -----Original Message-----
> > > From: Daniel P. Berrange [mailto:berrange@redhat.com]
> > > Sent: Tuesday, September 13, 2016 5:23 PM
> > > To: Gonglei (Arei)
> > > Cc: qemu-devel@nongnu.org; virtio-dev@lists.oasis-open.org; Huangpeng
> > > (Peter); Luonengjun; mst@redhat.com; stefanha@redhat.com;
> > > pbonzini@redhat.com; Huangweidong (C); mike.caraman@nxp.com;
> > > agraf@suse.de; xin.zeng@intel.com; Claudio Fontana; nmorey@kalray.eu;
> > > vincent.jardin@6wind.com
> > > Subject: Re: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff
> > >
> > > On Tue, Sep 13, 2016 at 11:52:09AM +0800, Gonglei wrote:
> > > > In previous patch, we define CryptoLegacyHWOptions in
> > > > qapi-schema.json. we introduce the new/delete funciton
> > > > about crypto legacy hardware device.
> > >
> > > Isn't virtio-crypto / cryptodev an entirely new specification ?
> >
> > Yes, it's an complete new device.
> >
> > > I'm surprised to be seeing something completely new described
> > > as "legacy". Can you explain this in more detail.
> > >
> > Because there are two kind of crypto device, one is virtio-crypto which is
> > a virtual crypto device (And virtio-crypto device is a real crypto device seen by
> the guest).
> > The other is cryptodev backend device.  I have no good idea to name the
> kind
> > of virtio-crypto device, so named to legacy crypto device refer to Net stuff.
> >
> > Do you have any suggestion? Thanks!
> 
> How about just calling it 'Backend' instead of 'Legacy' then ?
> 
It sounds reasonable I think. Because the virtio specification usually say
The backend device.... and The frontend driver....

So let's:

s/cryptoLegacyHW/cryptoBackendHW/g


Regards,
-Gonglei