Subject: RE: [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler
Hi Ola, > -----Original Message----- > From: Ola Liljedahl [mailto:Ola.Liljedahl@arm.com] > Sent: Tuesday, September 13, 2016 7:53 PM > To: Paolo Bonzini; Daniel P. Berrange; Gonglei (Arei) > Cc: email@example.com; firstname.lastname@example.org; Huangpeng > (Peter); Luonengjun; email@example.com; firstname.lastname@example.org; Huangweidong > (C); email@example.com; firstname.lastname@example.org; email@example.com; Claudio > Fontana; firstname.lastname@example.org; email@example.com > Subject: Re: [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue > handler > > > > > > On 13/09/2016, 12:58, "firstname.lastname@example.org on behalf of Paolo > Bonzini" <email@example.com on behalf of > firstname.lastname@example.org> wrote: > > > > > > >On 13/09/2016 11:20, Daniel P. Berrange wrote: > >>> > +typedef struct CryptoPacket CryptoPacket; > >>> > +typedef struct CryptoQueue CryptoQueue; > >>> > +typedef struct CryptoPacketBuf CryptoPacketBuf; > >>> > + > >>> > +typedef void (CryptoPacketSent) (CryptoClientState *, int); > >> As previously, I'd expect naming of > >> > >> QCryptoCryptodevPacket > >> QCryptoCryptodevPacketBuf > >> QCryptoCryptodevQueue > >> > > > >Gonglei, > > > >you are copying a lot of code from network backends. > > > >I am not sure why you would need a queue for virtio-crypto rather than a > >direct connection between frontend and backend (and the backend would be > >QEMU crypto APIs, like Daniel suggested). > > What about backends implemented directly in HW? Bypass the middle man. > Make crypto offload meaningful for small size blocks. > As I said in other reply, I only provide interfaces, you can realize them according to different backend cryptodevs. Regards, -Gonglei > < Ola > > > > >Paolo > > > >--------------------------------------------------------------------- > >To unsubscribe, e-mail: email@example.com > >For additional commands, e-mail: firstname.lastname@example.org > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended recipient, > please notify the sender immediately and do not disclose the contents to any > other person, use it for any purpose, or store or copy the information in any > medium. Thank you.