Re: [virtio-dev] Re: [RFC PATCH v5 ] virtio-spec: Introduce new Receive-Segment-Coalescing feature for guest

[Jason Wang <jasowang@redhat.com>]

On 2016年12月19日 14:50, Wei Xu wrote:
> > >  #define VIRTIO_NET_HDR_GSO_NONE        0
> > >  #define VIRTIO_NET_HDR_GSO_TCPV4       1
> > > +#define VIRTIO_NET_HDR_RESERVED        2
> > >  #define VIRTIO_NET_HDR_GSO_UDP         3
> > >  #define VIRTIO_NET_HDR_GSO_TCPV6       4
> > > +#define VIRTIO_NET_HDR_RSC_NONE        5
> >
> > Why not reuse VIRTIO_NET_HDR_GSO_NONE?
>
> This feature works like general linux GSO from the perspective of
> functionality, while the idea was thoroughly derived from a
> specification of Microsoft Receive-Segment-Offload(RSC), since new
> feature bits have been introduced, it might be clearer to get an
> individual 'NONE' flag for it, how about keep it? 

Re-use the bit seems more clean. We may want to hear from other reviewers.

Thanks