[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification
On Mon, Feb 06, 2017 at 03:46:25PM +0000, Stefan Hajnoczi wrote: > On Mon, Feb 06, 2017 at 01:48:09AM +0000, Gonglei (Arei) wrote: > > > > +\item The device MUST set \field{max_size} to show the maximum size of > > > crypto request the device supports. > > > > > > In bytes? > > > > > > > +\item The device MUST set \field{max_cipher_key_len} to show the > > > maximum length of cipher key if the device supports CIPHER service. > > > > > > In bits or bytes? > > > > > > > +\item The device MUST set \field{max_auth_key_len} to show the maximum > > > length of authenticated key if the device supports MAC service. > > > > > > In bits or bytes? > > > > > > > All lengths in virtio crypto spec are bytes. > > Please move this before the first length field is defined: > > +\begin{note} > +The basic unit of all data length the byte. > +\end{note} And I'd rewrite as All data length fields specify the length in bytes. > > It should be at the beginning of the spec.
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]